perform some updates on exodus-core

[arthru]

see Exodus-Privacy/exodus#655

[codeurimpulsif]

Hi @arthru and thanks for working on this!

I don't understand why you remove the setup.py and other changes, can you explain it when it's finalize?

[arthru]

Hey 👋

PEP 517 promotes pyproject.toml in place of setup.py

This PEP has been approved in september 2017, almost 8 years ago, so it is time to use it !

(moreover, I don't remember how we used to work with setup.py, so it feels easier for me...)

[codeurimpulsif]

Looks good for me, can you please solve the conflict?

Then I will merge it!

[codeurimpulsif]

Thanks @arthru it's seems cool, but I also see a lot of new requirements: we try to keep only the main direct dependencies in our requirements.txt file, is there a reason to add all this new ones?

I also would like @pnu-s confirmation on this PR, but maybe he's to busy right now…

[arthru]

Direct dependencies are listed in pyproject.toml file (at https://github.com/Exodus-Privacy/exodus-core/pull/105/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R12 ) and requirements.txt contains all the dependency tree with version pinned

I saw in Exodus that Pipfile and Pipfile.lock are in use, I could replace the requirements.txt file by Pipfile.lock if preferred. Shall I do that ?

[codeurimpulsif]

Direct dependencies are listed in pyproject.toml file (at https://github.com/Exodus-Privacy/exodus-core/pull/105/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R12 ) and requirements.txt contains all the dependency tree with version pinned

Oh ok, it's more clear for me, thanks.

I saw in Exodus that Pipfile and Pipfile.lock are in use, I could replace the requirements.txt file by Pipfile.lock if preferred. Shall I do that ?

If it's ok for you yes it could be cool, we use Pipfile everywhere else, an harmonization would be perfect! Thanks

[Porkepix]

I think on the matter I saw lately the Python community move to uv (https://github.com/astral-sh/uv), where it seems to gather agreement as a very good thing that came to the Python ecosystem. (I also found https://github.com/mkniewallner/migrate-to-uv if we ever think we'd like to do the move at some point).

@arthru This means here the requirements.txt is kinda used like a lockfile, is this standard practice? I believe I never saw it done that way before.

[arthru]

there is not such thing as a standard practice with pinning dependencies in the python world

requirements.txt and Pipfile.lock seems to me the most usable file formats

it seems that uv generates the exact same file (see https://docs.astral.sh/uv/pip/compile/#locking-requirements ) as does pip-compile (provided in pip-tools)

[codeurimpulsif]

Yep, and we don't want to move from Pipfile for now ^^

[arthru]

I don't get what you said about pipfile because there is no Pifile in this repo

I just updated the requirements.txt file because it was present

should I add a pipfile ? or pipfile.lock ?

[codeurimpulsif]

Yes, you can add it if you want.

I said so because we already have Pipfile everywhere else on all Exodus Privacy projects. It seems this one is the only one still using requirements.txt, so it would be cool if we change this ^^