Closed
Conversation
jerjohste
commented
Feb 26, 2021
jerjohste
commented
- Addition of new pulse shapes (gaussian and tanh).
- Addition of a pulse sequence viewer to check sequence code will work
- Addition of pulse loop transfer feature
MatthieuDartiailh
requested changes
Feb 26, 2021
Member
MatthieuDartiailh
left a comment
MatthieuDartiailh
left a comment
There was a problem hiding this comment.
I gave this a quick read. May try to make a more thorough review later
| @@ -0,0 +1,86 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # ----------------------------------------------------------------------------- | |||
| # Copyright 2015-2018 by ExopyPulses Authors, see AUTHORS for more details. | |||
Member
There was a problem hiding this comment.
the copyright does not make sense, I would expect to see 2021
| """ | ||
| #: Amplitude of the pulse this should be a number between -1.0 and 1.0 | ||
| amplitude = Str('1.0').tag(pref=True, feval=Feval(types=Real)) | ||
| sigma = Str('10.0').tag(pref=True, feval=Feval(types=Real)) |
Member
There was a problem hiding this comment.
ideally a comment for sigma too
| @@ -0,0 +1,88 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # ----------------------------------------------------------------------------- | |||
| # Copyright 2015-2018 by ExopyPulses Authors, see AUTHORS for more details. | |||
| """ | ||
| #: Amplitude of the pulse this should be a number between -1.0 and 1.0 | ||
| amplitude = Str('1.0').tag(pref=True, feval=Feval(types=Real)) | ||
| sigma = Str('10.0').tag(pref=True, feval=Feval(types=Real)) |
| @@ -0,0 +1,42 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # ----------------------------------------------------------------------------- | |||
| # Copyright 2015-2018 by ExopyPulses Authors, see AUTHORS for more details. | |||
| sequence_vars = Typed(OrderedDict, ()).tag(pref=(ordered_dict_to_pref, | ||
| ordered_dict_from_pref)) | ||
|
|
||
Member
There was a problem hiding this comment.
please strip spaces when saving
|
|
||
| channel_num = len(table) | ||
| #fig, axs = plt.subplots(4,1, figsize=(15, 8)) | ||
| fig, axs = plt.subplots(channel_num,1, figsize=(15, 2.5*channel_num), |
Member
There was a problem hiding this comment.
using constrained_layout makes generally for nicer plots
| for k, v in infos.items(): | ||
| self.write_in_database(k, v) | ||
|
|
||
| def compile_and_plot(self, variables): |
Member
There was a problem hiding this comment.
I am not sure this belongs on the task. I feel like it would be better on the plugin.
|
|
||
| database_entries = set_default({'num_loop': 1}) | ||
|
|
||
| # def check(self, *args, **kwargs): |
Member
There was a problem hiding this comment.
Why are no checks actually done ?
|
|
||
| class TransferPulseLoopTask(InstrumentTask): | ||
| """Build and transfer a pulse sequence to an instrument. | ||
|
|
Member
There was a problem hiding this comment.
Since this make several several hypothesis on the driver it could be nice to list them.
Open
Member
|
Superseded by #27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.