Skip to content

[Due for payment 2026-03-04] [Onyx Audit] Remove canBeMissing from useOnyx #80095

Closed

Description

@fabioh8010

Coming from #71202.

In order to simplify useOnyx API (and consequently Onyx) let's work on proposing the removal of some configurations we think are anti-patterns / unnecessary at this point.

The canBeMissing configuration logs an alert (also Growl alert in dev) if Onyx returns undefined for that subscribed key. It is purely for identifying cases where useOnyx should be returning data but it isn’t. I don’t think we ever invested in actually track down these missing data logs that are sent to BE, and most of the time its purpose is being bypassed by contributors.

I assume that at this point it’s pretty useless and we could raise a discussion to propose removing it.

Activity

  1. mountiny commented on Jan 21, 2026

    @mountiny
    Contributor

    I assume that at this point it’s pretty useless and we could raise a discussion to propose removing it.

    Let's discuss this with Ionatan for sure

  2. moved this from LOW to HIGH in [#whatsnext] #qualityon Jan 22, 2026
  3. fabioh8010 commented on Feb 2, 2026

    @fabioh8010
    ContributorAuthor

    Got approval from Ionatan last week.

    I will prepare a proposal this week.

  4. fabioh8010 commented on Feb 11, 2026

    @fabioh8010
    ContributorAuthor

    Updates:

    • Posted proposal for internal review.
  5. fabioh8010 commented on Feb 11, 2026

    @fabioh8010
    ContributorAuthor

    Updates:

  6. fabioh8010 commented on Feb 12, 2026

    @fabioh8010
    ContributorAuthor

    Updates:

  7. self-assigned this
    on Feb 12, 2026
  8. fabioh8010 commented on Feb 13, 2026

    @fabioh8010
    ContributorAuthor
  9. fabioh8010 commented on Feb 17, 2026

    @fabioh8010
    ContributorAuthor

    Updates:

    • Updated Onyx PR with main and addressed comments, waiting for final review.
  10. 22 remaining items

  11. fabioh8010 commented on Mar 13, 2026

    @fabioh8010
    ContributorAuthor

    @mountiny Sorry, could we reopen it? I forgot to remove https://github.com/Expensify/eslint-config-expensify/blob/main/eslint-plugin-expensify/provide-canBeMissing-in-useOnyx.js from eslint-config-expensify. Will raise a quick PR on Monday.

  12. mountiny commented on Mar 15, 2026

    @mountiny
    Contributor

    thanks!

  13. fabioh8010 commented on Mar 17, 2026

    @fabioh8010
    ContributorAuthor
  14. melvin-bot commented on Mar 20, 2026

    @melvin-bot

    @fabioh8010, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. melvin-bot commented on Mar 20, 2026

    @melvin-bot

    @fabioh8010, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Mar 24, 2026

    @melvin-bot

    @fabioh8010, @mountiny Still overdue 6 days?! Let's take care of this!

  17. melvin-bot commented on Mar 26, 2026

    @melvin-bot

    @fabioh8010, @mountiny 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  18. fabioh8010 commented on Mar 27, 2026

    @fabioh8010
    ContributorAuthor

    @tgolen everything here is done now, could you close it? Thanks

  19. fabioh8010 commented on Mar 27, 2026

    @fabioh8010
    ContributorAuthor

    Actually I can close myself :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions