[No QA] Strict API: bump react-native-safe-area-context to >= 5.8.1 - #101820
roryabraham wants to merge 3 commits into
Conversation
5.8.1 moves the Jest mock into the package build so it no longer imports react-native/Libraries subpaths that fail under the Strict API. 5.10.0 is the latest 5.x but is blocked by min-release-age. Drop the 5.6.2 removeChild patch, which landed upstream in 5.9.0.
The podspec is unchanged aside from the version it reads from package.json, so only the version pins move.
|
@codex review |
|
@MelvinBot review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c72aad2ef3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - ReactNativeDependencies | ||
| - Yoga | ||
| - react-native-safe-area-context (5.6.2): | ||
| - react-native-safe-area-context (5.9.1): |
There was a problem hiding this comment.
The pod versions are manually advanced to 5.9.1, but the SPEC CHECKSUMS entry at line 4055 remains the checksum from 5.6.2. Because the podspec reads its version from the package metadata, CocoaPods computes a different checksum for 5.9.1; running the standalone npm run pod-install will therefore rewrite Podfile.lock instead of reproducing the committed lockfile. Regenerate the lock with CocoaPods and commit the resulting checksum.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Updated in 1b7bf37. SPEC CHECKSUMS now reads 6acf61f42ee0862bbe00ed7e6c11cd0b81b7f6e3, the SHA1 of the generated local podspec JSON for 5.9.1 (same value HybridApp's lockfile gets for this version).
|
🤖 Reviewed the bump. One thing to fix, everything else holds up. The Why I'm confident the checksum must change
Verified the rest of the reasoning in the description:
Worth an explicit QA pass on web. 5.9.0 also rewrote the web provider: insets are now clamped to the provider view's bounding rect, One caveat on scope: I reviewed this statically and did not run the app, because this environment can't install the bumped dependency — a web run here would have exercised 5.6.2 plus the old patch, not 5.9.1. Also worth confirming whether HybridApp's own iOS lockfile pins this pod and needs a matching bump; I couldn't check that from here. |
roryabraham
changed the title
CocoaPods checksums the generated local podspec JSON, which embeds the version, so the SPEC CHECKSUMS entry has to move with the version pins.
|
Addressed the stale No Mobile-Expensify companion PR is needed for this bump. HybridApp's lockfile pins the same path pod, and Expensify/Mobile-Expensify#14138 already moves its version pins and checksum to the same values (linked from #101446). |
|
Closing as a dupe |
2 participants
Explanation of Change
react-native-safe-area-context5.6.2 type-checks as part of this project. Under the Strict API its Jest mock importsreact-native/Libraries/...subpaths that no longer resolve (TS2307). That was fixed in 5.8.1 by moving the mock into the package build: appandflow/react-native-safe-area-context#7455.10.0 is the latest 5.x, but it was published 2026-09-16 and
.npmrcmin-release-age=7rejects it. 5.9.1 (2026-08-18) is the newest installable 5.x and is>= 5.8.1. No other dependency versions moved.Also dropped
patches/react-native-safe-area-context. The 5.6.2removeChildpatch landed upstream in 5.9.0 (appandflow/react-native-safe-area-context#746), so leaving it would failpatch-package.ios/Podfile.lockversion pins were updated to match; the podspec itself is unchanged aside from the version it reads frompackage.json.Fixed Issues
$ #101818
Tests
None. Looking at the diff, there are almost no runtime changes, with the only significant runtime change being appandflow/react-native-safe-area-context#730, which only affects old arch.
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop