Repository navigation
Conversation
react-native-worklets 0.12.0 removed WorkletRuntime::runGuarded, so the library no longer compiles with worklets 0.12.0 and 0.13.0. Since 0.7.0 runGuarded was a deprecated forwarder to runSync(worklet, args...), which still exists in 0.13.0, so runSync works across the whole peer range.
|
I have read the CLA Document and I hereby sign the CLA Tomasz Żelawski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Contributor
|
Please also update the compatibility table with react-native-worklets in README.md |
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR description is AI-generated.
Analogous to expo/expo#48691
Details
react-native-worklets 0.12.0 removed
WorkletRuntime::runGuarded, so the library no longer compiles against worklets 0.12.0 and 0.13.0 (apple/MarkdownParser.mm:226:31: error: no member named 'runGuarded' in 'worklets::WorkletRuntime').I replaced the two
runGuardedcalls inapple/MarkdownParser.mmandandroid/src/main/cpp/MarkdownParser.cppwithrunSync, and updated the comments that mentionedrunGuarded.I did not add a version check and I kept the peer range at
react-native-worklets >=0.7.0. From 0.7.0 through 0.11.x,runGuardedwas already a deprecated one-line forwarder torunSync(worklet, args...), and 0.13.0 still exposesrunSyncwith the same shape (RuntimeCallableacceptsstd::shared_ptr<SerializableWorklet>), so a single spelling compiles across the whole supported range.Behaviour is unchanged. In every supported version
runSyncreports a JS error to LogBox and returnsundefinedin debug builds, and throws in release builds. The existingtry/catchon iOS and thecatch (Exception e)aroundnativeParseinMarkdownParser.javaalready cover the throwing case.Related Issues
N/A
Manual Tests
clang++ -fsyntax-onlycompile ofapple/MarkdownParser.mm(iOS simulator SDK) andandroid/src/main/cpp/MarkdownParser.cppagainst the react-native-worklets 0.13.0 headers. Both pass.Linked PRs
N/A