FEAT: Add FloorplanCardEditor component and integrate with FloorplanCard#634
FEAT: Add FloorplanCardEditor component and integrate with FloorplanCard#634MrBearPresident wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
Hey @exetico Would you have some feedback. |
…te YAML help texts, and improve code structure Change ha-textfield to ha-input
|
Hi, Could you please let me know, if this is primary done by AI? It does say a bit about the quality, before I'm digging into the code. I really like the idea, and actually had something on my own todo-list, so thank you for doing this. With that said, it's primary limited to it's own file, so I'm not that worried about the changes :-) Have you checked if it's possible to unit-test those things? I've not checked the docs, regarding the editor.
|
|
We'd need to check if https://raw.githubusercontent.com/ExperienceLovelace/ha-floorplan/ccbf6a5afeffca6c185f3bf5dffaa2e8a53a5155/docs/_docs/floorplan/examples/floorplanner_home/floorplanner_home.svg is available as part of the unit-testing of the editor, I guess. Same goes for the background image, if that's in use. So units tests of;
|
So its written primarly by me but supported by AI.
I also wanted this. Makes it very clear what the problems are.
I know for sure bubble cards doesn't uses unit test because I helped Cloos a while on the editor side.
Also will need to check how we could do this. But for same reason as above it will take some time. |
Proposed change
This PR adds a visual editor that still heavily leans on yaml but makes it easier to be organised.
Type of change
Example configuration
see examples
Example printscreens/gif
Card selectable when adding a card

A default card is created, without rules

The example card from the documentation, with one extra unnamed rule.

Image settings


Default action settings and the rule editor
Additional information
Additional documentation needed.
Let discus what is needed first.
Checklist
If user exposed functionality or configuration variables are added/changed: