feat: implement pausable functionality for critical contract operations - #35
Merged
Divineifed1 merged 1 commit intoJul 30, 2026
Conversation
Contributor
|
@BigJohn-dev fix CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
Summary
Completes pausable functionality for critical contract operations in the
renaissance-vaultcontract, bringing it in line withrenaissance-bettingandrenaissance-rewards(which already ship a Pausable utility).The vault already had the infrastructure — a
Pausedstorage key and anensure_not_pausedguard on its critical functions — but the wiring was incomplete: there were no publicpause()/unpause()entry points, so the vault could never actually be paused, and pause failures surfaced as a misleadingInvalidAmounterror.Changes
vault/src/lib.rspause()/unpause()/is_paused()functions, gated to the vault admin via a newrequire_adminhelper (Address::require_auth).pause()is idempotent.pause/unpauseemitPaused/Unpausedevents logging the admin account that triggered the action.VaultError::Paused(208) variant (plusUnauthorized(209)).ensure_not_pausednow returnsPauseddirectly instead of masquerading asInvalidAmount.deposit,withdraw,lock_for_bet,payout— already calledensure_not_paused, so they now revert with the clearPausederror when the vault is paused.vault/src/test.rssoroban-sdk21.4.0 (stale.get_address()/.mint()/AddressEnvTestUtilsAPI, 87 errors). Rewrote it to the current SDK API, matching the working patterns in the betting crate, preserving all prior coverage.pause/unpausetoggle state;pauseidempotencyPaused/Unpausedevents emitted and logging the adminpauserequires admin authdeposit/withdraw/lock_for_bet/payoutrevert withPausedwhile pausedunpauseAcceptance criteria
pause()/unpause()protected by an admin/owner checkdeposit,withdraw,lock_for_bet,payout)VaultError::Paused)pause()/unpause()emitPaused/Unpausedevents logging the triggering account