-
Notifications
You must be signed in to change notification settings - Fork 2
Minimum Firmware Check Before Script Updates #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check if the script update requires newer firmware than what is installed, if it does, then warn the user before updating.
Bump Script Version
Yeah, it's a good idea to give users a heads-up about the F/W version restrictions before updating the script. Everything looks good. I'll approve the PR now and then run the latest code through the Linter tool. Also, there are a couple of wording changes I'd like to make in the messages to have the intended meaning much clearer. |
Martinski4GitHub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Approved!!
P.S.
I'll just make a few wording changes to clearly convey the intended meaning.
Thanks @Martinski4GitHub ! I appreciate the feedback on the ideas implementation. Looking forwards to seeing how it comes out of the linter tool, and any additional changes you might suggest. I've go no issues at all with some wording changes either 😉 Hope you've been doing good! I'm still trying to get some stuff lined up with my move in the new province. Things like my health card, and the car plates. But otherwise I'm doing good! I'm expecting to have those 2 things done by next month hopefully. |
The code came out "clean as a whistle" - just as we like it!!! 👍😉
I've been very busy at work since the 1st week of January, which is normal around this time of year since that's when new projects and/or new features, enhancements, or major implementation overhauls are planned for the rest of the year and often the next couple of years. So new assignments or priorities may change, and some people may get shuffled around to other teams, but still within the same Engineering departments. Other than that, life has been fairly quiet around here (which is a very good thing in my book :>).
Yeah, especially when moving to a new province/state, things can take a little longer to settle down. I remember when I moved to the East Coast and then the Midwest for undergraduate and graduate school for my CS degrees. It was fun but also stressful at the beginning, while all the little things finally got settled. Glad to hear you're doing well and, slowly but surely, getting your new place and personal stuff in order. Have a great weekend, bud!!! |





Minimum Firmware Check Before Script Updates
To address: https://www.snbforums.com/threads/merlinau-v1-5-8-the-ultimate-firmware-auto-updater.96306/post-980918
WebUI notice:

Email Notice:

Shell Script Notice:
