[OCG] Fix: Save event when there are hidden sections#1
Open
[OCG] Fix: Save event when there are hidden sections#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://msf-ocg.atlassian.net/browse/DHIS-710
Analysis
It can be reproduced here: https://dhis2-uat.ocg.msf.org/dhis-web-capture/index.html#/new?orgUnitId=LHiU8UzwTGW&programId=HVo0WnZXaLI
Debugging the code, I found that the section "Pregnancy Status" (SN9dbnc770B) was not present in the validation object
state.formsSectionsFieldsUI: https://github.com/dhis2/capture-app/blob/v1.53.1/src/core_modules/capture-core/components/DataEntry/withSaveHandler/withSaveHandler.js#L298That's because the state only holds values for visible sections, and that section is only visible for Women (program rule yCnazxYijZI takes care of that).
Deploy