Skip to content

[refactor]: Convert side-effects from useMemo to useEffect in iFramePortal#183

Merged
MiquelAdell merged 2 commits intodevelopmentfrom
refactor/iframe-escape-portal-effects
Apr 28, 2026
Merged

[refactor]: Convert side-effects from useMemo to useEffect in iFramePortal#183
MiquelAdell merged 2 commits intodevelopmentfrom
refactor/iframe-escape-portal-effects

Conversation

@deeonwuli
Copy link
Copy Markdown
Contributor

📌 References

📝 Implementation

  • Replaced useMemo with useEffect + useState in IframeEscapePortal.
  • Extract getTopAccessibleWindow() into src/webapp/utils/topAccessibleWindow.ts so the parent-window resolution logic is shared instead of duplicated.
  • Added a clarifying comment in useApplyRules.getValueAndVerifyCondition explaining why visibility/disabled/enabled rules evaluate against the form's base period rather than the section's offset period.

🎨 Screenshots

Screenshot 2026-04-27 at 16 51 23

🔥 Notes to the tester

  • Check if the validation rules popup is at the bottom right of the current viewable screen and not the entire page in the new data entry app.

#869d1mfbp

@deeonwuli deeonwuli changed the title [refactor]: [refactor]: Convert side-effects from useMemo to useEffect in iFramePortal Apr 27, 2026
@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Apr 27, 2026

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
1.52MB (+27B 0%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Copy Markdown
Contributor

@MatiasArriola MatiasArriola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor, thanks @deeonwuli!

Copy link
Copy Markdown
Contributor

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comes from the analysis here:
#174

@MiquelAdell MiquelAdell merged commit 7b92aa8 into development Apr 28, 2026
6 checks passed
@MiquelAdell MiquelAdell deleted the refactor/iframe-escape-portal-effects branch April 28, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants