fix(GridForm): keep horizontal scroll on narrow screens#184
Merged
MiquelAdell merged 1 commit intodevelopmentfrom Apr 29, 2026
Merged
fix(GridForm): keep horizontal scroll on narrow screens#184MiquelAdell merged 1 commit intodevelopmentfrom
MiquelAdell merged 1 commit intodevelopmentfrom
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
GridWithCatOptionCombos wrapped its DataTable directly in DataTableSection with no overflow container and no min-width on data column headers. On a narrow viewport the table tried to fit in 100% of the parent and column headers compressed below their intrinsic width, garbling text like "Treatment successful" into "Treatme[nt]\nsuccessful". Wrap the table in a `overflow-x: auto` div and add `min-width: 8em` on data column headers, matching the pattern already in place in GridForm / GridWithCombos / GridWithCategoryColumns. Switch the DataTable from `width="100%"` to `width="initial"` so the table can grow beyond the wrapper when min-widths require it; the existing `minWidth: 100%` on the table class still keeps it filling the container on wide screens.
MiquelAdell
force-pushed
the
fix/grid-form-narrow-screen-overflow
branch
2 times, most recently
from
049ee53 to
2dd8ab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GridFormlose their horizontal scrollbar on narrow screens because the wrapper'soverflow: autois only applied whensection.fixedHeaders === true. With no overflow handling, the table is forced below its declared columnmin-widthand headers wrap into garbled text.overflow-x: autoon the wrapper whenever fixed headers are not enabled, so narrow viewports always get a horizontal scrollbar. Sections that opt intofixedHeaders: truekeep their existing sticky-header wrapper unchanged.GridWithTotals,GridWithCombosandGridWithCategoryColumns.Reported by
WHO/GTB user in Kenya, via Jo: section 6.1 (treatment outcomes by cohort year) shows squashed, garbled column headers on a small screen. Section 2.6 on the same form is fine — the difference is the wrapper.
ClickUp
869d3d8q7 — Grid sections without
fixedHeadershave no horizontal scroll on narrow screensTest plan
gridsection that has many columns (e.g. 6.1 treatment outcomes). Before the fix: headers wrap into 2-line garbled text, no scrollbar. After the fix: a horizontal scrollbar appears at the section level and headers render on one line.grid-with-combos) still renders identically — no regression.fixedHeaders: true(none in the TUB datastore today, but present in other consumers) still gets the sticky-header behaviour withmaxHeight: 100vh.