Support for v42#578
Open
eperedo wants to merge 6 commits intofeature/new-dashboard-logic-869cfc51ufrom
Open
Conversation
Contributor
|
@eperedo Just did some quick checks using the new 'Add target values' which is using the new Data Entry app, and we are not getting anymore the validation pop-up warnings as soon as you enter data. They were shown on v40 as soon as you type a wrong value, but they are not kicking in when you use v42. Is this a limitation from new Data Entry or is there something not working in our code? How to replicate: for the project you show in your screenshot, try animals distributed 100 and goats 200. This on v40 is triggering a warning as soon as you type in 200, but on v42 it is not. |
…for dataentry v42
…ad of public Country dashboards were set to public read+write access (rw------), allowing any user to see all country dashboards regardless of their project assignments. Now sharing is restricted to the aggregated users and user groups from all projects within the country, matching the pattern already used by project dashboards. Adds migration 10 to regenerate all existing country dashboards with the corrected sharing settings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ps instead of public" This reverts commit a095da2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
dhis2.de.event.dataValueSavedand global variables likedhis2.de.currentExistingValue. Custom forms are generated after creating/editing a project and in actions "Add Target/Actual values"🔥 Notes for the reviewer
This PR depends on #577 because there's a lot of changes related to dashboard and this could avoid a lot of merge conflicts in the future.
🎨 Screenshots