Skip to content

[feature]: Display selection count message across data tables #344

Open
deeonwuli wants to merge 4 commits intodevelopmentfrom
feat/display-selection-count-message
Open

[feature]: Display selection count message across data tables #344
deeonwuli wants to merge 4 commits intodevelopmentfrom
feat/display-selection-count-message

Conversation

@deeonwuli
Copy link
Copy Markdown
Contributor

@deeonwuli deeonwuli commented Apr 20, 2026

📌 References

📝 Implementation

The d2-ui-components selection banner is only triggered when items are selected on other pages, so a user could select rows down the current page without any visual cue and apply an unintended bulk action.

  • Added useTableWithSelectionCount hook to track table selection
  • Replaced useObjectsTable calls with the new hook in UserListTable

📹 Screenshots/Screen capture

Screen.Recording.2026-04-20.at.10.25.41.mov

🔥 Testing

  • Users page: select a few rows on the current page only, banner shows the count and a Clear selection link
  • Users page: navigate to another page after selecting, existing "X items selected (Y on other pages)" banner still appears (no duplicate)
  • Users page: select all rows on the page → existing "All N items on this page are selected" banner still appears (no duplicate)
  • Users page: Clear selection link from our banner empties the selection

#869cqxtfn

@deeonwuli deeonwuli requested a review from MiquelAdell April 20, 2026 08:47
@ifoche
Copy link
Copy Markdown
Member

ifoche commented Apr 20, 2026

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Apr 20, 2026

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
1.41MB (+653B +0.04%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@deeonwuli deeonwuli requested a review from eperedo April 21, 2026 10:21
Copy link
Copy Markdown
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it would be useful to have this on d2-ui-components so we can have this change available for all of our apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants