[fix]: Allow leading dot in usernames for existing users#348
Open
deeonwuli wants to merge 1 commit intodevelopmentfrom
Open
[fix]: Allow leading dot in usernames for existing users#348deeonwuli wants to merge 1 commit intodevelopmentfrom
deeonwuli wants to merge 1 commit intodevelopmentfrom
Conversation
Member
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
DHIS2 accepts usernames starting with a dot (e.g.
.foo), but the strict username validation re-enabled in #345 rejects any username starting with a separator. This would make existing DHIS2 accounts with leading-dot usernames uneditable through this app.Follow-up to: PR #345 review comment
New users continue to be validated under the original strict rules.
📹 Screenshots/Screen capture
🔥 Testing
#869cyeajx