Skip to content

fix: normalize VerbNet resource name case in xref extractor #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhi-0203 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: normalize VerbNet resource name case in xref extractor #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/glazing/references/extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,9 @@ def _index_propbank_mappings(self, roleset: Roleset) -> None:
# Index lexlinks (frame-level mappings with confidence)
for lexlink in roleset.lexlinks:
# Normalize dataset names including "Framenet" variant
if lexlink.resource == "verbnet":
if lexlink.resource.lower() == "verbnet":
target_dataset: DatasetType = "verbnet"
elif lexlink.resource in ["FrameNet", "Framenet"]:
elif lexlink.resource in ["FrameNet", "Framenet", "framenet"]:
target_dataset = "framenet"
else:
msg = f"Unknown lexlink resource type: {lexlink.resource}"
Expand Down Expand Up @@ -332,7 +332,7 @@ def _index_propbank_mappings(self, roleset: Roleset) -> None:
for role in roleset.roles:
for rolelink in role.rolelinks:
# Normalize rolelink resource names
if rolelink.resource == "verbnet":
if rolelink.resource.lower() == "verbnet":
rolelink_target: DatasetType = "verbnet"
elif rolelink.resource in ["FrameNet", "Framenet", "framenet"]:
rolelink_target = "framenet"
Expand Down