feat: add passenger trip shell v1 - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<TripShell />) optimized for mobile viewports (320px, 375px, 390px, 430px) as well as tablet and desktop layouts.PassengerTripKnowledgePackandVoyageKnowledgeResultstructures generated by the Voyage Knowledge Factory.buildPassengerTripViewModel()(frontend/src/trip-shell/adapter.ts) forming an explicit presentation barrier that transforms factory output intoPassengerTripViewModel.UNKNOWNornullvalues.PORT INFORMATION (DESTINATION)section with an explicit non-assignment notice ("Known port facility — not yet confirmed for your sailing.").SUPPORTED,APPROVED,PUBLISH_ALLOWED,DRAFT,Method.INFERRED,UNKNOWN) or raw cryptographic hashes leak into visible passenger UI. PII notice precisely bounded to reusable trip knowledge.frontend/src/fixtures/reference_voyage_bellissima.jsonas reference/demo/test fixture only.my-cruiseroutes explicitly toReferenceTripShellPreview, cleanly separating demo preview from pure data-drivenTripShellPage.Open Contract Gaps
TripShellPagein production without static fixture wrappers.departure_time(17:00) &arrival_time(05:30): Present in raw booking confirmation but unverified in factory contract.itinerary_waypoints/sea_days(5–6 Oct At Sea): Waypoints not yet modeled inPassengerTripKnowledgePack.Scope Exclusions
Test & Validation Coverage
frontend/src/trip-shell/TripShell.test.tsx).dist/generated with zero errors).git diff --checkclean with zero whitespace issues.