fix: browser 추천 태그 유사도에 retrieval alias 적용 - #393
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes브라우저 추천 태그 alias 매칭
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR applies retrieval aliases to browser tag matching while preserving existing scoring and eligibility behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
관련된 이슈
close #392
작업 내용
RecommendationScorer만 retrieval query planner의 curated English alias를 사용하도록 수정했고, browser handoff의RecommendationTagMatcher는 한국어 canonical tag를 영어 상품 metadata에 literal substring matching하고 있었습니다.79.00 / FULL_ATTRIBUTE_MATCH, browser handofftagSimilarity=0.00으로 갈렸습니다.BrowserRerankingHandoffService가 기존RecommendationRetrievalQueryPlanner를 주입받아 matcher에 전달하고, matcher가aliasFor(TagInput)을 우선 사용하도록 수정했습니다. alias가 없으면 기존 canonical name fallback을 유지합니다.레귤러핏/베이지/라운드넥/니트가 영어 metadataregular-fit/beige/crewneck/knit에 4/4 match되어 browsertagSimilarity=1.00이 됩니다.캐주얼(STYLE)은 분모에서 제외됩니다.공유 사항
matched eligible tag count / eligible tag count를 유지합니다.SILHOUETTE/MATERIAL/DETAIL/COLOR, STYLE 제외,name + brand + categoryPath, lowercase substring, zero eligible=1.00계약을 유지합니다.RETIRED,R1_1_IMPLEMENTATION_READY=NOT_APPLICABLE입니다.R2_NEEDS_REVALIDATION,R2_IMPLEMENTATION_READY=NO입니다. PR A price/value는HOLD입니다.NOT_RUN입니다. main merge/deploy 및 production 요청은 실행하지 않았습니다.검증
npm test --prefix scripts/poc/fashion-clip-browser: 34/34 PASSGRADLE_USER_HOME=/tmp/fitback-browser-alias-gradle ./gradlew clean build --no-daemon --no-watch-fs: 1003/1003 PASSgit diff --check: PASS체크리스트
스크린샷 (선택)
리뷰 요구사항 (선택)
Summary by CodeRabbit