Merged
Conversation
cwjames1983
approved these changes
Mar 19, 2026
Collaborator
|
I haven't gone over every single doc string line by line, but the snippets I did read seem pretty good, so I think these new docs are at least on the same level of accuracy - and more comprehensive - than previous docs |
cwjames1983
approved these changes
Mar 19, 2026
Collaborator
cwjames1983
left a comment
There was a problem hiding this comment.
As per above comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Claude to improve the doc strings and generate
a proper doc in docs/ about the code.
I am sure it has hallucinated a bit, but am hopeful it is primarily
correct.