Skip to content

Update AmpArmIOTalonFX.java#43

Open
RuotT wants to merge 5 commits into
mainfrom
CHRP-PART-3
Open

Update AmpArmIOTalonFX.java#43
RuotT wants to merge 5 commits into
mainfrom
CHRP-PART-3

Conversation

@RuotT

@RuotT RuotT commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

This may fix the volume issue

@RuotT
RuotT requested a review from JRTaylord March 15, 2024 00:51
forgot about the error statement
@RuotT

RuotT commented Mar 16, 2024

Copy link
Copy Markdown
Contributor Author

Added the if statement

@JRTaylord JRTaylord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add in logic to the amp arm subsystem to make sure the sound stops playing when the robot is enabled

Comment thread src/main/java/frc/robot/hardware/AmpArmIOTalonFX.java Outdated
Comment thread src/main/java/frc/robot/hardware/AmpArmIOTalonFX.java
@RuotT

RuotT commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

fixed everything

RuotT added 2 commits March 18, 2024 17:50
idk if I fix this mainly with the AmpArmIO layer
Now the merge conflict is fixed
@RuotT

RuotT commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants