IO Layers optimized#43
Conversation
… into KeirnanTest
… into KeirnanTest
| // } | ||
| // } | ||
|
|
||
| System.out.println("hello world"); |
There was a problem hiding this comment.
Can you remove this print because it causes a performance hit and it's not providing any diagnostic utility?
| public class AlgaeRollerIOPB extends AlgaeRollerIOCB { | ||
|
|
||
| /** Creates a new AlgaeIntakeRollerIOPB. */ | ||
| public AlgaeRollerIOPB() { |
There was a problem hiding this comment.
You'll need to include the super(); keyword
There was a problem hiding this comment.
How do I implement the keyword? Do I use it after extends and then state the class a second time (with IOCB layer)?
| private final SparkMax wheelMotor = new SparkMax(CompBotConstants.CLIMBER_ROLLER_ID, MotorType.kBrushless); | ||
| private final RelativeEncoder encoder = wheelMotor.getEncoder(); | ||
| private final PIDController pid = new PIDController(0, 0, 0); // TODO: find pid values | ||
| protected final SparkMax wheelMotor; |
There was a problem hiding this comment.
The climberwheel no longer exists on main so this isn't needed and will go away once you merge in from main
There was a problem hiding this comment.
Should I delete the file or just the code I changed?
…alized, converting many constants to variables. The code builds
| public class AlgaeArmIOPB extends AlgaeArmIOCB{ | ||
|
|
||
| /** Creates a new AlgaeArmIOPB. */ | ||
| public AlgaeArmIOPB() { |
There was a problem hiding this comment.
Needs to call super(); in the constructor
There was a problem hiding this comment.
If the config code below is identical to the config code in the super class, delete this
…d with no errors.
4 participants
Practice bot IO layer now extends Comp bot IO layer for each subsystem. Note that this branch was also used as a demonstration, so ensure no test code is still present. The only changes that were supposed to have been made were the IO layer changes in subsystems.