Loop times: Go brrrrrrrrr (~30-40ms savings)#29
Open
qwertychouskie wants to merge 5 commits into
Open
Conversation
qwertychouskie
changed the title
qwertychouskie
force-pushed
the
jacobsImprovements-rebased
branch
4 times, most recently
from
9bade71 to
ea34847
Compare
Member
Author
|
@stheyounger This is going to be even more important with the extra color sensors being added. 4 color sensors updating all 4 values every loop is 16 values, which will be ~80ms per loop just on the color sensors. |
qwertychouskie
force-pushed
the
jacobsImprovements-rebased
branch
2 times, most recently
from
93cdf00 to
1d557ac
Compare
qwertychouskie
force-pushed
the
jacobsImprovements-rebased
branch
from
1d557ac to
da66a53
Compare
qwertychouskie
force-pushed
the
jacobsImprovements-rebased
branch
from
da66a53 to
f750bc4
Compare
Should help reduce load on the GC a fair bit
Only update one color read per sensor per loop cycle. Certain aspects of collector sensing now theoretically have slightly longer peak possible latency, but the overall loop time savings are well worth it. Tested to function via telemetry, needs real drive testing as well.
qwertychouskie
force-pushed
the
jacobsImprovements-rebased
branch
from
f750bc4 to
3ca6faa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateSlot/totalUpdateSlotsneeds a re-think, right now it's a no-op. Getting this right will cut off another ~5ms of loop time. That said, everything should be fine in its current state, though it is technically possible (albeit quite unlikely) that the rebase broke something.