feat: fix issues with PNPM - #185
Conversation
|
Why? I dont really want to have to maintain support for 2 different package managers, can you not just use NPM? |
36306d1 to
14a4f4f
Compare
added @ant-design icons as a top-level dependency because unlike npm, pnpm will refuse to hoist transitive dependencies.
14a4f4f to
fabbf4c
Compare
I can, however I prefer pnpm as it is pretty much compatible with npm in all ways, and it saves space by using sym-links for same dependencies across multiple projects/worktrees. I removed the pnpm-specific files since those are not really necessary but @ant-design/icons being hoisted is a change I hope you can welcome as it doesn't affect npm usage and it is in fact being used as a top-level dep. If you'd rather not out of principle (i.e., not wanting to receive more PRs in regards to compat with different package managers) then I understand and you can close the PR. P.S: Also regenerated package-lock.json because otherwise CI builds fail since there's a new top-level dependency |
|
Hey, this PR is still updating depedencies. Unfortunately I have to be quite picky about PRs that update deps due to secuirty concerns. I have gone ahead and updated all deps myself in this #186 PR, and also set a min release age for deps to 7. Alongside also adding @ant-design/icons as a top level import to fix your PNPM issues. |
|
That's completely fine, given that the change was made in the end I am happy about the result. Thanks for looking into it! |
2 participants
adds PNPM-specific metadata files:
added @ant-design icons as a top-level dependency because unlike npm, pnpm will refuse to hoist transitive dependencies.
Given this project uses npm by default, it isn't strictly necessary to commit the lock and workspace files, as those can be left untracked I can remove them. The package.json change however would be ideal if it can be accepted so that one doesn't have to be left with unstaged changes to the package.json when using pnpm as package manager