Unpick V4#42
Merged
Merged
Conversation
df025be to
47d5946
Compare
Player3324
approved these changes
Oct 25, 2025
# Conflicts: # src/main/java/daomephsta/unpick/impl/membercheckers/BytecodeAnalysisMemberChecker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpick V4 is a small update to the Unpick spec, designed to take advantage of the new magic constant annotations that Mojang has introduced. You can view the new spec here, and the diff compared to the previous V3 spec here. Please let me know if there are any problems with this new spec.
The first commit implements the necessary changes to the file format and the tree/visitor API, and the second commit implements annotations into the bytecode uninliner (plus tests). As usual, an Unlicense version of the parser along with its tests are found here.
To use the new API, simply continue using the
UnpickV3*classes, they work with unpick v4 too.