Skip to content

Peer Review - #4

Open
tonyzhang0510 wants to merge 1 commit into
Fahertyk-NU:project-4-designfrom
tonyzhang0510:main
Open

Peer Review#4
tonyzhang0510 wants to merge 1 commit into
Fahertyk-NU:project-4-designfrom
tonyzhang0510:main

Conversation

@tonyzhang0510

Copy link
Copy Markdown

Strengths

  • Solves a real, specific problem with actual domain logic rather than a generic CRUD app. The RMD status rules seem to be built by someone who understands the real workflow.
  • Clean, well-organized code with clear separation of routes, database, and middleware, and consistent structure throughout.
  • Good use of server-side MongoDB aggregation to compute dashboard and summary totals instead of doing it on the client.
  • Thorough documentation: the README covers author, class link, deployed link, design doc, demo video, build steps, and AI disclosure.
  • Some nice product touches, like distribution settings carrying over year to year, that show attention to the end user.

Weaknesses

  • Some logic is repeated across a few files and could get out of sync over time.
  • Data routes aren't scoped to the logged-in user, so one advisor could see another's accounts.
  • Raw error messages are sent straight to the client instead of generic ones.
  • The session secret falls back to a hardcoded default if the environment variable is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants