Skip to content

[luv-33] Default Claude to Opus 5#33

Merged
NiveditJain merged 1 commit into
mainfrom
luv-33
Jul 25, 2026
Merged

[luv-33] Default Claude to Opus 5#33
NiveditJain merged 1 commit into
mainfrom
luv-33

Conversation

@NiveditJain

Copy link
Copy Markdown
Member

Switches the built-in Claude model default from claude-opus-4-8 to claude-opus-5.

Changes

  • luv/__init__.py — model fallback in both launch() and resume(), plus the -m help text
  • README.md — "How it works" step 4 and the -m MODEL flag row
  • tests/test_agents.py — default-model assertion

The -m MODEL flag still overrides the default, and Codex still uses its own CLI default.

Testing

python3 -m unittest discover -s tests — 5 tests, all pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01A3WHRCgoASnNqs58bazDoQ

Switch the built-in Claude model default from claude-opus-4-8 to
claude-opus-5 in both launch() and resume(), and update the help
text, README, and default-model test to match. The -m flag still
overrides; Codex is unaffected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A3WHRCgoASnNqs58bazDoQ

@hermes-exosphere hermes-exosphere left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PASS] Approved

Straightforward model-default bump: claude-opus-4-8 -> claude-opus-5 in three locations (launch, resume, help text) plus test assertion and README. No logic changes — just a string swap.

What is good:

  • All 5 tests pass
  • No debug leftovers, no secret leaks
  • README and help text kept in sync with code
  • -m MODEL override path unchanged (user can still pin a specific model)

@hermes-exosphere

Copy link
Copy Markdown
Contributor

Code Review Summary

Verdict: Approved ✅ (0 issues, 0 suggestions)

PR: #33 — [luv-33] Default Claude to Opus 5
Author: @NiveditJain
Files changed: 3 (+6 −6)

✅ Looks Good

  • luv/init.py — model fallback strings in launch() (L389), resume() (L334), and -m help text (L724) all consistently updated from claude-opus-4-8claude-opus-5
  • tests/test_agents.py:62assertIn("claude-opus-5", argv) correctly validates the new default
  • README.md — "How it works" step 4 (L61) and -m MODEL flag row (L90) updated in sync
  • The -m MODEL flag still overrides the default (no logic change — just a string swap)
  • Codex path untouched (still uses its CLI default, as documented)
  • All 5 tests pass (python3 -m unittest discover -s tests)
  • No debug leftovers, no secret leaks

What was read end-to-end

  • luv/__init__.py (901 lines) — full file, verified both model paths
  • tests/test_agents.py (74 lines) — full file, verified all assertions
  • README.md (164 lines) — full file

Reviewed by Hermes Agent

@NiveditJain
NiveditJain merged commit dff6089 into main Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants