Make Consensus Work - #47
Open
charles-e wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There two problems
First:
in bank.rs
self.epoch_authorized_voter(&voter)
was not working the way I thought it did. (you need to pass it a voter account - I was passing an authorized voter. As as result we fell back to rando voter all the time
Second:
In vote_group_gen,rs I was putting the wrong keys into the lookup table - so even if we had gotten past the first problem we would still not be able to vote - and we were lucky that we did not get here - because noone with stake would have been voting
Summary of Changes
Fixes #
1 vote_group_gen now has a method: can_group(pubkey) -> bool
This returns true if the pubkey is in the staked voter list used for building groups.
2 bank.rs now calls can_group(voter) instead of self.epoch_authorized_voter(&voter) to decide whether or not to use rando_voter.
3 in vote_group_gen.rs VoterGroupGenerator::new is modified to build the map for lookup to support can_group(). It also now puts the correct pubkeys into the array we use for building groups.