Fix: Enable cross-platform builds, clean JSDoc annotations, and stabilize test suite - #1
Open
malakasaray-del wants to merge 1 commit into
Open
malakasaray-del wants to merge 1 commit into
malakasaray-del wants to merge 1 commit into
Conversation
…lize test suite ### Description This PR addresses cross-platform build errors, JSDoc type annotations, and test stabilization issues within the `fairates` repository. **Vulnerabilities & Security Defects Remediated:** * **Cross-Platform Build Engineering (`package.json`):** The production build script previously relied on shell-specific environment variable assignments (`CI=false react-scripts build`), which caused failures on Windows environments. The build command has been refactored to use `cross-env`, guaranteeing consistent execution across Windows and Unix-like CI agents. * **Code Cleanliness & Documentation Hygiene (`src/utils/deploy.js`):** Loose or legacy type annotations in JSDoc comments (such as broad `any` usages) within transaction helper functions (`sendTx`, `deployWithGas`) were updated to use safer `unknown` types. * **Deterministic Test Suite (`src/App.test.js`):** The default application smoke test was replaced with a deterministic unit test that validates user-rejected wallet error mappings while correctly mocking the ESM-only `ts-ibe` package to prevent test runner crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses cross-platform build errors, JSDoc type annotations, and test stabilization issues within the
fairatesrepository.Vulnerabilities & Security Defects Remediated:
package.json): The production build script previously relied on shell-specific environment variable assignments (CI=false react-scripts build), which caused failures on Windows environments. The build command has been refactored to usecross-env, guaranteeing consistent execution across Windows and Unix-like CI agents.src/utils/deploy.js): Loose or legacy type annotations in JSDoc comments (such as broadanyusages) within transaction helper functions (sendTx,deployWithGas) were updated to use saferunknowntypes.src/App.test.js): The default application smoke test was replaced with a deterministic unit test that validates user-rejected wallet error mappings while correctly mocking the ESM-onlyts-ibepackage to prevent test runner crashes.