Skip to content

ci: bump cargo-zigbuild to 0.23.4 to fix aarch64-linux-gnu build - #141

Merged
barakb merged 1 commit into
mainfrom
fix/ci-cargo-zigbuild-cortex-a53
Sep 8, 2026
Merged

barakb merged 1 commit into
mainfrom
fix/ci-cargo-zigbuild-cortex-a53

Conversation

@barakb

@barakb barakb commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The stable - aarch64-unknown-linux-gnu CI job has been failing at link time:

error: linking with `/root/.cache/cargo-zigbuild/0.19.8/zigcc-aarch64-unknown-linux-gnu-aef7.sh` failed: exit status: 1
  = note: error: unsupported linker arg: --fix-cortex-a53-843419
error: could not compile `text-to-cypher-node` (lib) due to 1 previous error

Cause

Recent Rust versions pass -Wl,--fix-cortex-a53-843419 when linking for aarch64-unknown-linux-gnu (rust-lang/rust#155453). The cargo-zigbuild 0.19.8 zigcc wrapper forwards that flag straight to Zig's linker, which rejects it. Since the build step runs rustup update stable before building, the job started failing as soon as a Rust release containing that change went out.

Fix

cargo-zigbuild 0.23.0 filters the argument out (rust-cross/cargo-zigbuild#452, src/zig/linker_args.rs). This bumps the pinned version from 0.19.8 to 0.23.4 in every zig-based matrix entry, keeping ci.yml and release.yml in sync:

  • ci.yml: x86_64-unknown-linux-musl, aarch64-unknown-linux-gnu
  • release.yml: x86_64-unknown-linux-musl, aarch64-unknown-linux-gnu, aarch64-unknown-linux-musl

cargo-zigbuild 0.23.4 requires Rust 1.88+, which is already satisfied by the preceding rustup update stable.

Verification

CI on this PR exercises the previously failing aarch64-unknown-linux-gnu cross-compile plus the musl target.

The `stable - aarch64-unknown-linux-gnu` job fails at link time with:

    error: unsupported linker arg: --fix-cortex-a53-843419

Recent Rust versions pass `-Wl,--fix-cortex-a53-843419` when linking for
aarch64-unknown-linux-gnu (rust-lang/rust#155453), but cargo-zigbuild
0.19.8's zigcc wrapper forwards it to Zig's linker, which rejects it.

cargo-zigbuild 0.23.0 filters that argument out
(rust-cross/cargo-zigbuild#452). Bump the pin to 0.23.4 in both ci.yml
and release.yml, keeping the two workflows in sync.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 8, 2026 06:26
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f8853fc7-553f-4f0b-8bda-aff520d957ab


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward, consistent version pin update across the relevant CI/release workflow steps and is unlikely to impact runtime code behavior.

Pull request overview

This PR updates the GitHub Actions workflows to pin a newer cargo-zigbuild version so Zig-based cross-compilation jobs (notably aarch64-unknown-linux-gnu) succeed with newer Rust link flags.

Changes:

  • Bump cargo-zigbuild from 0.19.8 to 0.23.4 in CI zig-based build matrix entries.
  • Bump cargo-zigbuild from 0.19.8 to 0.23.4 in release workflow zig-based build matrix entries.
File summaries
File Description
.github/workflows/release.yml Updates the pinned cargo-zigbuild version used for Zig-based cross targets in release builds.
.github/workflows/ci.yml Updates the pinned cargo-zigbuild version used for Zig-based cross targets in CI builds.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@barakb
barakb merged commit 75cbf1e into main Sep 8, 2026
16 checks passed
@barakb
barakb deleted the fix/ci-cargo-zigbuild-cortex-a53 branch September 8, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants