fix: preserve file theme icons on tree path nodes#37
Merged
FanaticPythoner merged 1 commit intoMay 29, 2026
Merged
Conversation
Restrict icon resource URI assignment to non-tag path nodes so tag rows keep dedicated tag icons and file containers continue using file theme resources. Tree icon flow: - add resource and grouping metadata on workspace, path, and flat nodes - route `resourceUri` through helper methods that honor `showBadges` - select folder/file icons from node metadata instead of shared fallback logic Configuration and manifest updates: - update `showBadges` text to include file icon theme resource behavior - replace animated busy placeholder icons with static product icons Validation artifacts: - add manifest and behavioral coverage for issue #29 icon ownership scenarios - add #29 runtime benchmark JSON and markdown snapshots with latency/RSS comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict icon resource URI assignment to non-tag path nodes so tag rows keep dedicated tag icons and file containers continue using file theme resources.
Tree icon flow:
resourceUrithrough helper methods that honorshowBadgesConfiguration and manifest updates:
showBadgestext to include file icon theme resource behaviorValidation artifacts: