Skip to content

fix: restore labels, codicon aliases, and issue branch flow#39

Merged
FanaticPythoner merged 3 commits into
masterfrom
fix/issues-28-36-not-quite-a-drop-in-replacement-label-format-after-displays-before
May 30, 2026
Merged

fix: restore labels, codicon aliases, and issue branch flow#39
FanaticPythoner merged 3 commits into
masterfrom
fix/issues-28-36-not-quite-a-drop-in-replacement-label-format-after-displays-before

Conversation

@FanaticPythoner

Copy link
Copy Markdown
Owner

Prefix-only regex matches that contain ($TAGS) keep the physical-line
suffix available to displayText and ${after} across editor and workspace scans.

Detection:

  • extend non-multiline ($TAGS) regex matches to the physical line end before tag extraction
  • preserve whole-match tags for explicit regexes without ($TAGS)
  • cover legacy prefix regex, default labels, and workspace normalization

Icons:

  • generate codicon alias names instead of codepoints
  • parse "$(icon)" syntax through a shared helper for tree, gutter, and configuration checks
  • keep malformed codicon syntax invalid before alias lookup

Workflow:

  • add issue-derived branch recipes for full flow and standalone branch steps
  • derive default branch names from GitHub issue numbers and titles
  • create local and remote branches from upstream master without pushing master
  • move source-branch changes onto the issue branch, stage them, wait for commit, then push the issue branch
  • prompt for PR creation after branch push with yes as the default answer

Docs and artifacts:

  • document prefix-only regex suffix rendering and octicon/codicon icon syntax
  • replace checked-in perf JSON with markdown benchmark summaries
  • ignore generated perf JSON artifacts

Fixes #28
Fixes #36

Prefix-only regex matches that contain ($TAGS) keep the physical-line
suffix available to displayText and ${after} across editor and workspace scans.

Detection:
- extend non-multiline ($TAGS) regex matches to the physical line end before tag extraction
- preserve whole-match tags for explicit regexes without ($TAGS)
- cover legacy prefix regex, default labels, and workspace normalization

Icons:
- generate codicon alias names instead of codepoints
- parse "$(icon)" syntax through a shared helper for tree, gutter, and configuration checks
- keep malformed codicon syntax invalid before alias lookup

Workflow:
- add issue-derived branch recipes for full flow and standalone branch steps
- derive default branch names from GitHub issue numbers and titles
- create local and remote branches from upstream master without pushing master
- move source-branch changes onto the issue branch, stage them, wait for commit, then push the issue branch
- prompt for PR creation after branch push with yes as the default answer

Docs and artifacts:
- document prefix-only regex suffix rendering and octicon/codicon icon syntax
- replace checked-in perf JSON with markdown benchmark summaries
- ignore generated perf JSON artifacts

Fixes #28
Fixes #36
Issue branch staging now transfers only the source branch index while
rejecting unstaged tracked edits and untracked files before branch switch.

Branch workflow:
- create issue branches without temporary origin/master tracking
- keep issue branch upstreams pointed at origin/<branch>
- reject non-project issue URLs and non-master base branches
- force pull requests to FanaticPythoner/better-todo-tree master
- pass explicit gh repo, base, and head arguments to skip fork prompts
Resolves an issue where extracted text from block comments (e.g., multi-line, HTML) incorrectly included the trailing comment delimiters (`*/`, `-->`).

This change introduces new utility functions to accurately identify and remove these trailing end tokens from the detected match text. The new `trimTrailingEndToken` and `trimTrailingMultiLineCommentEnd` functions are integrated into the match normalization process, ensuring that the `displayText` and `after` properties only contain the relevant comment content.

To support this, a `resolveBlockCommentPattern` utility centralizes the logic for determining the correct block comment pattern for a given file type, including language aliases (e.g., Markdown to HTML, Haskell to C++).

Fixes #28
@FanaticPythoner FanaticPythoner merged commit de9aec4 into master May 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label format - ${after} displays ${before} Not quite a drop-in replacement

1 participant