fix: preserve edited default regex scans that require PCRE2#43
Merged
FanaticPythoner merged 2 commits intoMay 30, 2026
Conversation
Custom regexes derived from the default pattern keep candidate-based workspace scans while raw ripgrep searches add PCRE2 only when required. Regex engine: - detect lookaround and backreference syntax outside escaped and character-class spans - respect explicit ripgrep engine arguments before adding --pcre2 - keep $TAGS PCRE2 regexes on candidate scans with local normalization User surface: - document automatic PCRE2 selection and explicit engine overrides in nls strings - add deterministic issue #42 benchmark coverage for raw, PCRE2, and candidate routes Coverage: - cover regex classification, ripgrep args, workspace scan routing, and markdown task rendering Fixes #42
PCRE2-only $TAGS regexes that use non-JavaScript backreference syntax stay on raw ripgrep normalization instead of entering candidate scans. Regex engine: - classify brace, subroutine, and Python-style named backreferences as PCRE2 - exclude JavaScript-incompatible tag regexes from candidate scans - keep Rust-compatible and explicit-engine ripgrep paths unchanged Workspace normalization: - skip exact JavaScript RegExp construction for incompatible PCRE2 backrefs - normalize raw ripgrep payloads from the returned match text Docs and perf: - document automatic PCRE2 selection and explicit engine overrides - refresh issue #42 user-flow benchmark evidence Fixes #42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom regexes derived from the default pattern keep candidate-based workspace
scans while raw ripgrep searches add PCRE2 only when required.
Regex engine:
User surface:
Coverage:
Fixes #42