Skip to content

fix: separate status-bar and activity-bar count domains#44

Merged
FanaticPythoner merged 1 commit into
masterfrom
fix/issue-41-hidefromstatusbar-hidefromactivitybar
May 30, 2026
Merged

fix: separate status-bar and activity-bar count domains#44
FanaticPythoner merged 1 commit into
masterfrom
fix/issue-41-hidefromstatusbar-hidefromactivitybar

Conversation

@FanaticPythoner

Copy link
Copy Markdown
Owner

Route status-bar totals through status-bar counts while activity badges and
non-current-file tree title counts retain the activity-bar count domain.

Runtime behavior:

  • add a shared tag-count reducer for status, activity, badge, and title totals
  • keep hideFromStatusBar isolated from hideFromActivityBar in total and tag modes
  • update command-context cache entries after every setContext promise resolves
  • use declarative notification text for regex migration and view placement prompts

Coverage and evidence:

  • cover total status counts, tag status counts, and activity badge counts with split domains
  • cover setContext retry behavior after a rejected command context update
  • add issue hideFromStatusBar / hideFromActivityBar #41 user-flow benchmark markdown snapshot with latency/RSS comparisons
  • update .gitignore for stronger JSON matching in the artifacts directory

Fixes #41

Route status-bar totals through status-bar counts while activity badges and
non-current-file tree title counts retain the activity-bar count domain.

Runtime behavior:
- add a shared tag-count reducer for status, activity, badge, and title totals
- keep hideFromStatusBar isolated from hideFromActivityBar in total and tag modes
- update command-context cache entries after every setContext promise resolves
- use declarative notification text for regex migration and view placement prompts

Coverage and evidence:
- cover total status counts, tag status counts, and activity badge counts with split domains
- cover setContext retry behavior after a rejected command context update
- add issue #41 user-flow benchmark markdown snapshot with latency/RSS comparisons
- update .gitignore for stronger JSON matching in the artifacts directory

Fixes #41
@FanaticPythoner

Copy link
Copy Markdown
Owner Author

@FALLAI-Denis

Would you mind testing it on your side? I thoroughly tested it, but a different set of eyes is always welcome... Thank you! I'd like to merge this into master within ~1h, so please let me know! 😊

@FALLAI-Denis

Copy link
Copy Markdown

Hi @FanaticPythoner,

Version 1.1.17 : seem not OK...

  • [ ] / unlock and [x] / lock : both excluded from status bar
  • [x] / lock : excluded from Activity bar and Tree
image image

--> [ ] / unlock present in status bar...

note : icons are not same in Tree and Status bar ?

  • octicons in Tree
  • codicon in Status bar?

@FanaticPythoner

FanaticPythoner commented May 30, 2026

Copy link
Copy Markdown
Owner Author

Hey @FALLAI-Denis ! 1.1.17 does not have the changes in this PR... The point here would be for you to review and test this PR (in order to validate if it's fully fixing your issues in issue 41) prior to merging it in master, which would then enable me to create a patch (new) release (1.1.18)!

@FanaticPythoner FanaticPythoner merged commit dde246e into master May 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hideFromStatusBar / hideFromActivityBar

2 participants