fix: centralize regex sources and harden scan flows#52
Merged
FanaticPythoner merged 2 commits intoMay 31, 2026
Conversation
Regex construction routes runtime, tests, workflow checks, release checks, perf harnesses, and evidence tooling through a typed registry while preserving scan parity. Regex registry: - add shared fragments, named patterns, tag placeholders, default regex constants, builder helpers, and typed registry errors - replace duplicated literals in detection, utils, attributes, highlights, icons, tree, stream scanning, config, webpack, perf, release, workflow, parity, and test code - add an equivalence harness that covers 81/81 baseline sources, 73/73 behavior cases, and zero non-registry regex literals Scan and command flow: - extend candidate workspace scans to JavaScript-compatible custom $TAGS regexes with balanced structure and zero-width tails - keep PCRE2-only backreference regexes on raw ripgrep normalization - wrap registered commands in a shared async boundary and return persistence, reveal, export, and migration work - roll back workspace-state writes before refresh work when multi-entry writes fail Ripgrep and evidence: - return RipgrepError for option, executable, spawn, JSON, cleanup, and cancellation failures - prevent stale search cleanup from clearing newer active searches - add registry, scan parity, ripgrep, workflow, release, and perf coverage plus accuracy and candidate-scan artifacts - ignore generated accuracy JSON and local settings exports Fixes #51
Branch staging applies staged and unstaged source patches separately, retains source-base snapshots, and merges fallback snapshot content against updated target files. Regex evidence resolves a CI-safe baseline, registers CodeQL workflow assertion patterns, and keeps busy-command icon assertions aligned with static product icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regex construction routes runtime, tests, workflow checks, release
checks, perf harnesses, and evidence tooling through a typed registry
while preserving scan parity.
Regex registry:
constants, builder helpers, and typed registry errors
highlights, icons, tree, stream scanning, config, webpack, perf,
release, workflow, parity, and test code
73/73 behavior cases, and zero non-registry regex literals
Scan and command flow:
$TAGS regexes with balanced structure and zero-width tails
persistence, reveal, export, and migration work
multi-entry writes fail
Ripgrep and evidence:
and cancellation failures
coverage plus accuracy and candidate-scan artifacts
Fixes #51