Always use uint8 for t2count and reverseH in buildBinaryFuse#52
Merged
lemire merged 1 commit intoFastFilter:masterfrom Jan 14, 2026
Merged
Always use uint8 for t2count and reverseH in buildBinaryFuse#52lemire merged 1 commit intoFastFilter:masterfrom
lemire merged 1 commit intoFastFilter:masterfrom
Conversation
The values stored in these slices are independent of the fingerprint size. It looks like maybe a mistake when the code was converted to use generics. This improves build performance a bit (and reduces mem usage) for 16-bit fingerprints. On an M1 laptop: ``` name old time/op new time/op delta BinaryFusePopulate/16/n=1000000-10 29.4ms ± 1% 28.1ms ± 1% -4.25% (p=0.000 n=10+10) name old MKeys/s new MKeys/s delta BinaryFusePopulate/16/n=1000000-10 34.1 ± 1% 35.6 ± 1% +4.44% (p=0.000 n=10+10) name old alloc/op new alloc/op delta BinaryFusePopulate/16/n=1000000-10 28.1MB ± 0% 26.0MB ± 0% -7.58% (p=0.000 n=8+9) name old allocs/op new allocs/op delta BinaryFusePopulate/16/n=1000000-10 8.00 ± 0% 8.00 ± 0% ~ (all equal) ```
Member
|
Very nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values stored in these slices are independent of the fingerprint
size. It looks like maybe a mistake when the code was converted to use
generics.
This improves build performance a bit (and reduces mem usage) for
16-bit fingerprints. On an M1 laptop: