Core engine#206
Merged
Merged
Conversation
…process - Updated the GET function to include checking the status of the commit process on S3, using metadata.json. - Implemented logic to return a 'completed' status if the theme is ready or if the theme.zip file exists. - Improved error handling when checking for the existence of ProcessId and interacting with S3.
- The `getCdnUrlForKey` function has been implemented to centrally generate CDN URLs across multiple services. - Previous URL generation implementations have been removed from the code, improving consistency and maintainability. - The template loading and theme storage functions have been updated to use the new CDN functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(cdn): Centralized CDN URL generation
getCdnUrlForKeyfunction has been implemented to centrally generate CDN URLs across multiple services.