refactor(profile): Simplify the construction of public URLs for images#213
Merged
Conversation
- Dependencies in `package.json` and `package-lock.json` have been updated to ensure compatibility and performance. - Improvements have been made to domain validation routes and asset management in the API, optimizing code structure and readability.
- Comments describing the creation of collections and menus in `collectionService.ts` and `menuService.ts` have been removed to improve code clarity. - Import paths in several files within `renderer-engine` and `tenant-domains` have been configured to use relative paths, improving code organization.
- Removed unnecessary logger logs in the `loadDataStep` function to improve code clarity. - Configured import paths in `index.ts` to use relative paths, improving code organization.
- Manual construction of public URLs in the `useUpdateProfilePicture`, `useLogoUpload`, and `useProductImageUpload` hooks has been replaced with a CDN utility, improving code clarity and reusability. - Environment variable dependencies related to S3 and CloudFront have been removed, simplifying the URL retrieval logic.
Stivenjs
added
documentation
Stivenjs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.