Conversation
This commit removes the 'authenticated' authorization for various fields in the user store model and updates the 'storeStatus' field to include specific authorization rules. These changes improve the security model by ensuring that only the owner and public API key can access certain operations, aligning with best practices in user data management.
…omponents This commit updates the handling of environment variables across multiple files, changing references from 'NODE_ENV' to 'APP_ENV' for consistency. Additionally, it refactors the theme management components, enhancing the ThemeList and ThemeUploadForm for better user experience and functionality. The ThemeModals are also improved with streamlined modal actions, and new theme actions such as renaming and previewing themes are introduced, ensuring a more robust theme management process.
This commit introduces the Shopify Polaris AppProvider to the layout, enabling consistent styling and internationalization support. The StoreSelector component is refactored to improve the user experience by implementing a new layout structure, integrating a UserMenu, and enhancing the StoreData component with better loading states and error handling. Additionally, the useUserStores hook is updated to separate active and inactive stores, improving data management and user feedback.
This commit updates the StoreSelector component to utilize Tailwind CSS for styling, enhancing the layout's responsiveness and visual appeal. Key changes include adjustments to the card structure, header alignment, and loading state presentation, ensuring a better user experience across different screen sizes.
…elector tests with AppProvider wrapper
This commit modifies the StoreCard component by increasing the gap between elements for better visual spacing and changing the HTML structure to enhance semantic meaning. The store name is now displayed without inline styles, and the domain text is updated to use a paragraph tag for improved accessibility and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the 'authenticated' authorization for various fields in the user store model and updates the 'storeStatus' field to include specific authorization rules. These changes improve the security model by ensuring that only the owner and public API key can access certain operations, aligning with best practices in user data management.