Conversation
…eAuthenticationMiddleware This commit adds a comment to the handleStoreMiddleware function, clarifying that the session being retrieved has already been validated in the handleAuthenticationMiddleware. This improves code readability and understanding of the session management flow within the middleware.
This commit updates the PolarWebhookProcessorService to handle various formats of customer IDs from the webhook payload, improving the robustness of user identification. It introduces a fallback mechanism to retrieve the external ID using the customer ID if the initial lookup fails. Additionally, the PolarService is modified to accommodate new customer ID fields, ensuring consistent data mapping. These changes enhance the reliability of subscription processing and user management.
This commit removes the validation for plan price in the subscription logic, streamlining the conditions for determining valid subscriptions. The logic now focuses solely on the validity of the subscription ID, enhancing clarity and maintainability of the code.
…ility function This commit refactors the PolarWebhookProcessorService and SubscriptionService to utilize a new utility function, extractPlanPrice, for calculating plan prices from the webhook data. This change improves code readability and maintainability by centralizing the price extraction logic, ensuring consistency across services. Additionally, a polyfill for Request and Response is added in jest.setup.ts to support testing with the Polar SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.