Skip to content

fix(collection-form): update button text and correct store ID referen… #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stivenjs merged 1 commit into from
Jun 1, 2025
Merged

fix(collection-form): update button text and correct store ID referen… #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/store/components/product-management/collection-form/form-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export function FormPage() {
onClick={handleDeleteCollection}
disabled={isSubmitting}
>
{isSubmitting ? 'Eliminando...' : 'Eliminar colección'}
{isSubmitting ? 'Eliminar colección' : 'Eliminar colección'}
</Button>
)}
<Button
Expand Down
9 changes: 3 additions & 6 deletions app/store/components/product-management/utils/collection-form-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ export const useCollectionForm = ({
setInitialSelectedProducts(collectionData.products)
}

// Mark data as loaded
setIsDataLoaded(true)
} else if (!isEditing) {
// Para nueva colección, establecer valores por defecto
Expand All @@ -126,14 +125,12 @@ export const useCollectionForm = ({
imageUrl: '',
})

// Mark data as loaded for new collections too
setIsDataLoaded(true)
}
}, [isEditing, collectionData])

// Detectar cambios en el formulario
useEffect(() => {
// Only check for changes if data is loaded and not submitting
if (isDataLoaded && !isSubmitting) {
const currentState = {
title,
Expand Down Expand Up @@ -166,7 +163,7 @@ export const useCollectionForm = ({
initialFormState,
initialSelectedProducts,
isSubmitting,
isDataLoaded, // Add this dependency
isDataLoaded,
])

// Función para añadir un producto a la selección
Expand All @@ -191,7 +188,7 @@ export const useCollectionForm = ({

// Función para guardar la colección
const handleSaveCollection = async () => {
if (!currentStore?.id || !user?.userId) {
if (!currentStore?.storeId || !user?.userId) {
toast.error('No se pudo identificar la tienda o el usuario')
return
}
Expand Down Expand Up @@ -282,7 +279,7 @@ export const useCollectionForm = ({
try {
await deleteCollection.mutateAsync(collectionId)
toast.success('Colección eliminada correctamente')
router.push(routes.store.collections(storeId))
router.push(routes.store.products.collections(storeId))
// No desactivamos isSubmitting para mantener el botón deshabilitado hasta la redirección
} catch (error) {
console.error('Error deleting collection:', error)
Expand Down