Skip to content

Templates engine #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stivenjs merged 2 commits into from
Jun 7, 2025
Merged

Templates engine #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fcc8da
feat(template-loader): configure S3 client with dynamic region and cr…
Stivenjs Jun 7, 2025
949624c
feat(template-loader): initialize S3 client with dynamic region and c…
Stivenjs Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/api/stores/template/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,16 @@ interface TemplateFile {
}

// Configuración de S3
const s3Client = new S3Client()
const s3Client = new S3Client({
region: process.env.REGION_BUCKET || 'us-east-2',
credentials:
process.env.ACCESS_KEY_ID && process.env.SECRET_ACCESS_KEY
? {
accessKeyId: process.env.ACCESS_KEY_ID,
secretAccessKey: process.env.SECRET_ACCESS_KEY,
}
: undefined,
})

const BUCKET_NAME = process.env.BUCKET_NAME || ''
const CLOUDFRONT_DOMAIN = process.env.CLOUDFRONT_DOMAIN_NAME || ''
Expand Down Expand Up @@ -210,7 +219,7 @@ function generateTemplateUrls(
const baseUrl =
CLOUDFRONT_DOMAIN && APP_ENV === 'production'
? `https://${CLOUDFRONT_DOMAIN}`
: `https://${BUCKET_NAME}.s3.${process.env.AWS_REGION_BUCKET || 'us-east-2'}.amazonaws.com`
: `https://${BUCKET_NAME}.s3.${process.env.REGION_BUCKET || 'us-east-2'}.amazonaws.com`

urls[path] = `${baseUrl}/${key}`
})
Expand Down
11 changes: 10 additions & 1 deletion lib/store-renderer/services/template-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,16 @@ class TemplateLoader {

// Solo inicializar S3 si tenemos bucket configurado
if (this.bucketName) {
this.s3Client = new S3Client()
this.s3Client = new S3Client({
region: process.env.REGION_BUCKET || 'us-east-2',
credentials:
process.env.ACCESS_KEY_ID && process.env.SECRET_ACCESS_KEY
? {
accessKeyId: process.env.ACCESS_KEY_ID,
secretAccessKey: process.env.SECRET_ACCESS_KEY,
}
: undefined,
})
}
}

Expand Down