Feat/two step admin rotation - #1133
Merged
Ejirowebfi merged 2 commits intoAug 24, 2026
Merged
Conversation
- Add propose_admin, accept_admin, cancel_admin_proposal entrypoints - Proposals expire after ADMIN_PROPOSAL_TTL_LEDGERS (~28 h) and require the incoming address to sign, eliminating accidental rotation to an uncontrolled key - transfer_admin / update_admin become aliases for propose_admin; no single-step rotation path remains - New error codes: NoPendingProposal (24), ProposalExpired (25) - New events: adm_prop, adm_acc, adm_can - Bump CURRENT_SCHEMA_VERSION to 4; add schema-v4 migration step (adds pending_admin / pending_admin_expiry to FactoryState) - Replace single-step admin tests with full two-step test suite (pending->accept, cancel, wrong proposee, overwrite, expiry, legacy aliases, schema-v4 migration) - Update docs/contract-abi.md, docs/incident-response.md, docs/mainnet-deployment-checklist.md, README.md Closes Favourorg#1095
Closed
10 tasks
|
🎉 This PR is included in version 1.5.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
closes #1012