Skip to content

fix: run public release publication gate on macOS #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FernandoAbishai merged 1 commit into from
Aug 13, 2026
Merged

fix: run public release publication gate on macOS #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-unsigned.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ jobs:
name: Publish verified GitHub prerelease
if: ${{ inputs.publish == true }}
needs: [build, clean-runner-verify]
runs-on: ubuntu-latest
runs-on: macos-14
permissions:
contents: write

Expand Down
2 changes: 2 additions & 0 deletions scripts/check-release-workflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,15 @@ function validateWorkflowText(text, { candidateWorkflowText = fs.readFileSync(ci
assert(!/id-token:\s+write|attestations:\s+write/.test(clean), 'clean runner has build-only attestation permissions');

assert(/if:\s+\$\{\{ inputs\.publish == true \}\}/.test(publish), 'publish job is not gated on publish=true');
assert(/runs-on:\s+macos-14/.test(publish), 'publish runner must be macos-14 for native DMG verification');
assert(/contents:\s+write/.test(publish), 'publish contents permission is missing');
assert(!/id-token:\s+write|attestations:\s+write|artifact-metadata:\s+write/.test(publish), 'publish job has unnecessary attestation permissions');
assert(/PUBLISH_UNSIGNED_ALPHA/.test(publish), 'publication confirmation gate is missing');
assert(/real_model/.test(publish), 'publication real-model gate is missing');
assert(/refs\/heads\/main/.test(publish) && /origin\/main/.test(publish) && /GITHUB_SHA/.test(publish), 'publication main-current gate is missing');
assert(/--prerelease/.test(publish) && /--latest=false/.test(publish), 'publication prerelease/latest semantics are missing');
assert(/actions\/download-artifact@v4/.test(publish), 'publish job must download verified output');
assert(/node scripts\/check-public-release\.js --dir dist\/public-release --dmg/.test(publish), 'publish job native DMG verification gate is missing');
assert(!/release:rc:arm64|electron-builder/.test(publish), 'publish job must not rebuild the artifact');
const createRelease = stepBlock(publish, 'Create exact GitHub prerelease without rebuilding');
assert(/git fetch origin main --force[\s\S]*test "\$\(git rev-parse origin\/main\)" = "\$GITHUB_SHA"[\s\S]*gh release create/.test(createRelease), 'release mutation step lacks an immediate main-current recheck');
Expand Down