Skip to content

fix(ci): pass the crates.io token to FerrFlow in reusable-ferrflow-release #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryanFRD merged 1 commit into from
Sep 20, 2026
Merged

fix(ci): pass the crates.io token to FerrFlow in reusable-ferrflow-release #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/reusable-ferrflow-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ jobs:
# Lets cargo-based postBump hooks read the private Kellnr index.
# Empty (and unused) for repos that don't consume Kellnr.
CARGO_REGISTRIES_KELLNR_TOKEN: ${{ secrets.CARGO_REGISTRIES_KELLNR_TOKEN }}
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_FERRLABS_REGISTRY_TOKEN }}

@ferrfleet ferrfleet Bot Sep 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the name mismatch is explained in the PR description but not in the file. Someone reading just the YAML sees CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_FERRLABS_REGISTRY_TOKEN }}, assumes a typo, "fixes" it to secrets.CARGO_REGISTRY_TOKEN, and publishing silently breaks again. The Kellnr line above carries a comment; this one should too.

Suggested change
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_FERRLABS_REGISTRY_TOKEN }}
# crates.io credential. The names deliberately differ: the org secret
# that actually publishes to crates.io is CARGO_FERRLABS_REGISTRY_TOKEN,
# not the identically-named CARGO_REGISTRY_TOKEN. See #355.
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_FERRLABS_REGISTRY_TOKEN }}

with:
dry_run: ${{ inputs.dry-run }}
force_version: ${{ inputs.force-version }}
Expand Down Expand Up @@ -116,6 +117,7 @@ jobs:
- uses: FerrLabs/FerrFlow@426168a76625bb663c397fb0b5a21e4aefdecc68 # v7.21.1
env:
CARGO_REGISTRIES_KELLNR_TOKEN: ${{ secrets.CARGO_REGISTRIES_KELLNR_TOKEN }}
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_FERRLABS_REGISTRY_TOKEN }}
with:
mode: publish
dry_run: ${{ inputs.dry-run }}
Expand Down
Loading