fix(renovate): keep chart majors out of the FerrLabs charts group - #357
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Checked against the full default.json at head: with matchUpdateTypes: ["patch", "minor"] the org charts rule no longer applies groupName, minimumReleaseAge: 0 or automerge: true to a major. The preceding Kubernetes infra rule is patch/minor-only too, so a chart major is not re-captured there either and lands on the global one-day age plus the final major / automerge: false rule, as the description states. The branch-level automerge collapse this fixes matches generateBranchConfig behaviour.
Nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FerrLabs chartsrule had nomatchUpdateTypes, so majors joined the group. Grouping ignores the major/minor split, andgenerateBranchConfigturns the branch's automerge off as soon as one upgrade in it carriesautomerge: false— which the last rule of the file gives majors. A pending chart major would therefore have blocked the very patch and minor bumps the rule exists to fast-track.patchandminor. A major now falls through to the global one-day age and stays an ungrouped manual PR, which is the behaviour it had before chore(renovate): let FerrLabs charts through without the one-day wait #354.Test plan
default.jsonparses, diff is the four added lines plus the reworded description