Skip to content

fix(ci): sign the image even when the CVE scan fails #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryanFRD merged 1 commit into from
Sep 20, 2026
+6 −1
Merged

fix(ci): sign the image even when the CVE scan fails #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/reusable-docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,12 @@ jobs:

cosign:
name: cosign (sign + attest)
needs: [build, trivy]
# Deliberately not gated on `trivy`. The image is already pushed by the
# time the scan runs, so a failing scan does not withhold the artefact,
# only its signature, and consumers end up with an unsigned image that
# shipped anyway. A signature attests provenance, not the absence of
# CVEs; the scan keeps its own red check. See FerrTrack-Cloud#712.
needs: build
if: inputs.push
# cosign from its static binary (not cosign-installer, which needs
# envsubst/gettext absent from the minimal ARC image) so signing runs on the
Expand Down
Loading