Correção <> Remove chaves expostas #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes exposed API tokens from test files and documentation to improve security. The PR title translates to "Correction <> Remove exposed keys" in Portuguese.
Changes:
- Replaces actual API tokens with empty strings in all test files
- Updates README.md example to use an empty string instead of an exposed token
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/resources/users.spec.js | Removes exposed API token from test setup |
| test/resources/subscriptions.spec.js | Removes exposed API token from test setup |
| test/resources/plans.spec.js | Removes exposed API token from test setup |
| test/resources/metrics.spec.js | Removes exposed API token from test setup |
| test/resources/company.spec.js | Removes exposed API token from test setup |
| README.md | Removes exposed API token from usage example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const ProfitWell = require('profitwell') | ||
| const profitWell = new ProfitWell({ | ||
| apiToken: 'Wx15BlcpDfVPWbsTdNX<3' | ||
| apiToken: '' |
There was a problem hiding this comment.
The README usage example should provide a placeholder that guides users on where to obtain their API token, rather than an empty string. Consider using a descriptive placeholder like 'YOUR_API_TOKEN_HERE' or 'your-profitwell-api-token' with a comment explaining how to obtain it from the ProfitWell dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.