fix(RateChangeQueue): remove unreachable array clearing logic#269
Open
ZenGround0 wants to merge 1 commit intomainfrom
Open
fix(RateChangeQueue): remove unreachable array clearing logic#269ZenGround0 wants to merge 1 commit intomainfrom
ZenGround0 wants to merge 1 commit intomainfrom
Conversation
The isEmpty() check after delete was unreachable because: 1. We pass require(queue.head < c.length) to enter dequeue 2. delete doesn't change array length 3. isEmpty() checks queue.head == c.length, which can never be true This simplifies the dequeue function by always incrementing head. Fixes #266 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
prefer #272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #266. I went with the solution removing clearing array size entirely as this is minutely more efficient.