keyserver: share a link to specific email lookup#49
Open
SVilgelm wants to merge 3 commits into
Open
Conversation
Auto-fill the lookup form when an ?email= query parameter is present in the page URL and automatically submit the form. This adds a small client-side snippet that reads the "email" parameter, populates the lookup-email input, and triggers requestSubmit() on the lookup-form. This improves user experience by allowing direct links that pre-populate and run key lookups without extra clicks, useful for sharing and deep linking to specific email lookups. The change is isolated to the home template and does not affect existing lookup behavior when no parameter is provided.
Author
|
Not tested yet, cannot figure out how to run it locally |
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to auto-populate and auto-submit the email lookup form when an ?email= query parameter is present in the URL. This enables direct linking to specific email lookups.
- Client-side JavaScript reads the email query parameter from the URL
- Automatically fills the lookup form and triggers submission
- Enables deep linking and sharing of specific email lookups
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensure the email query parameter is read and applied only after the DOM has finished loading. Previously the script accessed and submitted the lookup form immediately, which could run before DOM elements were available and cause race conditions or errors. Wrapping the logic in a DOMContentLoaded listener guarantees the form and input exist before setting the value and programmatically submitting.
Author
|
Basically, I want an ability to share a link to automatically lookup for my email |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SVilgelm
changed the title
Author
|
@FiloSottile Could you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-fill the lookup form when an ?email= query parameter is present in the page URL and automatically submit the form. This adds a small client-side snippet that reads the "email" parameter, populates the lookup-email input, and triggers requestSubmit() on the lookup-form.
This improves user experience by allowing direct links that pre-populate and run key lookups without extra clicks, useful for sharing and deep linking to specific email lookups. The change is isolated to the home template and does not affect existing lookup behavior when no parameter is provided.