Fix unbounded receipt minting by adding MAX_USER_RECEIPTS cap - #953
Open
Peolite001 wants to merge 8 commits into
Open
Fix unbounded receipt minting by adding MAX_USER_RECEIPTS cap#953Peolite001 wants to merge 8 commits into
Peolite001 wants to merge 8 commits into
Conversation
🤖 Greptile AI Code ReviewGreptile will automatically review this PR (6 file(s) changed). Review gates:
|
Contributor
|
resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR bounds the number of receipts a single account can mint by introducing a
MAX_USER_RECEIPTScap. This prevents individual accounts from bloating the contract's storage footprint and slowing down the TTL sweep.Type of change
Related issue
Closes #884
Changes
MAX_USER_RECEIPTSconstant set to 1,000 incontracts/finchippay-contract/src/lib.rs.mint_receiptfunction to enforce the cap and panic with "User receipt limit reached" if the limit is exceeded.contracts/finchippay-contract/README.mdunder the "Bounded inputs" section.test_mint_receipt_capandtest_mint_receipt_cap_exceeded) to verify that minting works up to the limit and cleanly reverts when the cap is crossed.Testing
Screenshots (if UI change)
N/A
Checklist
main