This repository was archived by the owner on Dec 7, 2022. It is now read-only.
Add a cli option for producer encoding#86
Open
denisacostaq wants to merge 5 commits intomasterfrom
Open
Conversation
Be able to configure the encoder for the producer side Options: `model` or `base64`
1bb43fa to
81b33b5
Compare
142a546 to
d54b1f2
Compare
d54b1f2 to
172395c
Compare
172395c to
ec02b38
Compare
f4ebe09 to
701dab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
Be able to configure the encoder for the producer side
Options:
modelorbase64--producer_encoding Two possible values are accepted: model - if you want to send data encoded in a json mapping the model; or base64 if you want a base64 encoding. (env $PRODUCER_ENCODING) (default "model")Why
To be able to use kafka-connect to forward data directly from kafka to elasticsearch using:
'value.converter' = 'org.apache.kafka.connect.json.JsonConverter'is required to have the messages encoded injsonin the topic,base64messages does not work.Anything, in particular, you'd like to highlight to reviewers
This depends on Financial-Times/message-queue-go-producer#10
Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x
Scope and particulars of this PR (Please tick all that apply)
This Pull Request follows the rules described in our Pull Requests Guide